-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.codespell*,.github,*: add codespell configuration, workflow, fix codespell errors. #356
Conversation
beba279
to
b2015ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is okay to merge all the commits that are fixing typos ? That way we would end up with three commits one for the actual makefile target, one for GitHub Actions and the last one fixing the typos.
9c0d551
to
0c70ce8
Compare
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
0c70ce8
to
8e9ae19
Compare
Yes, I'll squash those and resubmit, this time without the tip-most commit (topology-aware), so then we could merge it right away, without causing too much conflict mayhem for myself in libmem. |
8e9ae19
to
d663aea
Compare
Fix existing spelling errors all over the repo. Signed-off-by: Krisztian Litkey <[email protected]>
Ignore temporarily spelling errors in the topology-aware policy for now. We have a pending PR with a huge blast radius right in there, and it is better to spellcheck it once that's merged and the dust settles. Otherwise we'd just create conflicts for code we're about to rework anyway. Signed-off-by: Krisztian Litkey <[email protected]>
d663aea
to
eac81ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @askervin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great to get these fixed now and in the future. :D
This PR
This PR will conflict with #332 if/when that gets merged. I'd prefer us to focus our limited review capacity on #332, Also, I expect reviewing this to mostly be a one-time skim-through. Therefore, I'll keep this a draft until #332 gets merged.