Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.codespell*,.github,*: add codespell configuration, workflow, fix codespell errors. #356

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Aug 27, 2024

This PR

  • adds codespell configuration
  • adds a codespell workflow
  • fixes existing spelling errors detected by codespell

This PR will conflict with #332 if/when that gets merged. I'd prefer us to focus our limited review capacity on #332, Also, I expect reviewing this to mostly be a one-time skim-through. Therefore, I'll keep this a draft until #332 gets merged.

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is okay to merge all the commits that are fixing typos ? That way we would end up with three commits one for the actual makefile target, one for GitHub Actions and the last one fixing the typos.

.codespellrc Outdated Show resolved Hide resolved
.github/workflows/codespell.yml Outdated Show resolved Hide resolved
@klihub klihub force-pushed the devel/codespell branch 3 times, most recently from 9c0d551 to 0c70ce8 Compare October 1, 2024 13:22
@klihub
Copy link
Collaborator Author

klihub commented Oct 1, 2024

Do you think it is okay to merge all the commits that are fixing typos ? That way we would end up with three commits one for the actual makefile target, one for GitHub Actions and the last one fixing the typos.

Yes, I'll squash those and resubmit, this time without the tip-most commit (topology-aware), so then we could merge it right away, without causing too much conflict mayhem for myself in libmem.

@klihub klihub marked this pull request as ready for review October 1, 2024 13:27
@klihub klihub requested a review from fmuyassarov October 1, 2024 13:27
klihub added 2 commits October 1, 2024 16:35
Fix existing spelling errors all over the repo.

Signed-off-by: Krisztian Litkey <[email protected]>
Ignore temporarily spelling errors in the topology-aware policy
for now. We have a pending PR with a huge blast radius right in
there, and it is better to spellcheck it once that's merged and
the dust settles. Otherwise we'd just create conflicts for code
we're about to rework anyway.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov
Copy link
Collaborator

ping @askervin

Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov fmuyassarov merged commit 7143934 into containers:main Oct 2, 2024
4 checks passed
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to get these fixed now and in the future. :D

@klihub klihub deleted the devel/codespell branch October 2, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants